Change test_extrusion_lsw python demo to rst demo#4852
Merged
connorjward merged 8 commits intofiredrakeproject:mainfrom Feb 10, 2026
Merged
Change test_extrusion_lsw python demo to rst demo#4852connorjward merged 8 commits intofiredrakeproject:mainfrom
connorjward merged 8 commits intofiredrakeproject:mainfrom
Conversation
ZiyaSelim
changed the title
connorjward
requested changes
Feb 3, 2026
Contributor
connorjward
left a comment
connorjward
left a comment
There was a problem hiding this comment.
Thanks!
Please also add this to the docs here. Before merging we'll also need to check that this renders correctly on the website. You can do this in the Docker container by going to firedrake_repo/docs and running make html.
Contributor
|
Unfortunately this is not passing tests: Looking at the RST file there appears to be inconsistent indentation for the Python snippets. |
connorjward
requested changes
Feb 4, 2026
connorjward
previously approved these changes
Feb 6, 2026
Contributor
connorjward
left a comment
connorjward
left a comment
There was a problem hiding this comment.
Awesome work. Thanks so much! I will merge if tests pass.
JHopeCollins
reviewed
Feb 6, 2026
Co-authored-by: Josh Hope-Collins <jhc.jss@gmail.com>
connorjward
requested changes
Feb 6, 2026
connorjward
approved these changes
Feb 10, 2026
Contributor
|
All done. Thank you! |
Contributor
Author
|
Thank you very much with all your help 😄 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #3864